Add drilling cost curves to geothermal cost cmod#1191
Merged
Conversation
injection drilling costs
14 tasks
sjanzou
approved these changes
Jul 30, 2024
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
What do we need to re-evaluate before the release?
| } | ||
|
|
||
| if (mp_geo_out->md_NumberOfWellsInj < 0) mp_geo_out->md_NumberOfWellsInj = 0; | ||
| if (mp_geo_out->md_NumberOfWells < 0) mp_geo_out->md_NumberOfWells = 0; |
Collaborator
There was a problem hiding this comment.
Both injection and regular wells drilled - good catch!
dguittet
reviewed
Jul 30, 2024
| { SSC_INPUT, SSC_NUMBER, "resource_depth", "Resource Depth", "m", "", "GeoHourly", "", "", "" }, | ||
| { SSC_INPUT, SSC_NUMBER, "geotherm.cost.prod_wells_drilled", "Number of drilled production wells", "0/1", "0=LargerDiameter,1=SmallerDiameter", "GeoHourly", "", "", "" }, | ||
| { SSC_INPUT, SSC_NUMBER, "geotherm.cost.inj_wells_drilled", "Number of drilled injection wells", "0/1", "0=LargerDiameter,1=SmallerDiameter", "GeoHourly", "", "", "" }, | ||
| { SSC_INPUT, SSC_NUMBER, "calc_drill_costs", "Calculate drill costs", "0/1", "0=LargerDiameter,1=SmallerDiameter", "GeoHourly", "?=0", "", "" }, |
Collaborator
There was a problem hiding this comment.
curious why you are using "." instead of "_"?
Collaborator
Author
There was a problem hiding this comment.
We've just been working off what was there before. It's probably worth changing this in the future.
|
|
||
| int calc_drill_costs = as_integer("calc_drill_costs"); | ||
| if (calc_drill_costs == 1) { | ||
| int inj_cost_curve_welldiam = as_integer("geotherm.cost.inj_cost_curve_welldiam"); |
Collaborator
There was a problem hiding this comment.
shouldn't these inputs be required if "calc_drill_costs"==1?
Collaborator
Author
There was a problem hiding this comment.
Yes, I will update this.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Add drilling cost curves to cmod for use in reV calculations
-Optional inputs to model, not used by default
-Re-evaluate for release