Skip to content

Sam 1738 correct net billing sell rate#1168

Merged
brtietz merged 3 commits into
patchfrom
sam_1738_correct_net_billing_sell_rate
May 29, 2024
Merged

Sam 1738 correct net billing sell rate#1168
brtietz merged 3 commits into
patchfrom
sam_1738_correct_net_billing_sell_rate

Conversation

@brtietz

@brtietz brtietz commented May 28, 2024

Copy link
Copy Markdown
Collaborator

Solves SAM issue NatLabRockies/SAM#1738:

  • Correct sell rate during tier changes
  • Fix behavior when passing through multiple tiers in one step.

test/input_cases/utility_rate_data/gen_25_year_residential_w_net_eqns.csv contains equations to develop test results

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the projects file from SAM NatLabRockies/SAM#1738 and updating the workbook values, the calculations look good across the tiers
image

Also, thanks for adding the tests!

@brtietz brtietz merged commit 6825d95 into patch May 29, 2024
@brtietz brtietz deleted the sam_1738_correct_net_billing_sell_rate branch December 13, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants