Modify index to year 1 index to correctly utilize tou demand function#1152
Merged
Conversation
…. Add unit test that captures the issue
dguittet
approved these changes
Mar 20, 2024
cpaulgilman
approved these changes
Mar 21, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good in the UI. I ran a simulation for the default PV Battery / Commercial case and all battery dispatch options and got no simulation errors. Retail rates did not display the error about demand TOU periods.
Collaborator
|
Issue reported in SAM forum: https://sam.nrel.gov/forum/forum-general/4659 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TOU demand function changed in https://github.com/NREL/ssc/pull/1135/files expects the year 1 index. Correct this, and add a test that reproduces the issue by setting up a multi-year rate forecast object.