For consistency, we should update the other occurrences of "if (dscr!=0)" :

That seems worth some discussion. If the debt fraction limits box is unchecked, I was under the impression we allowed negative DSCRs. Similarly, if a debt percent is specified, a negative DSCR is a valid outcome of this calculation. I'll add to the SAM team meeting agenda to discuss.

Also, (maybe a separate issue) we should update cmod_communitysolar to have the same max debt fraction checking and to have the dscr>0 check

I had filed NatLabRockies/SAM#1708 for that, thanks for the reminder on community solar. I had that tagged for the fall release, but happy to discuss which portions are patchable versus requiring a release.

Decision at 2/27 SAM meeting:

• Negative minimum DSCRs should be allowed for the debt % option
• If the maximum debt fraction box is unchecked, give a warning to the user if the debt percent goes negative.
• Create an issue (or see if another issue exists) to revisit the negative debt percent behavior.

Links to related issues now closed:

• Issue errors when PPA model results are out of range SAM#551
• Financial Parameters, Project Term Debt, DSCR model does not bound debt fraction SAM#534

@cpaulgilman Thanks, I added debt percent < 0 check to the check functions from https://github.com/NREL/ssc/pull/903/files. This is ready for a second review.