Skip to content

Expose snow slide coefficient in ssc#1128

Merged
mjprilliman merged 5 commits into
patchfrom
snow-slide-coeff
Feb 29, 2024
Merged

Expose snow slide coefficient in ssc#1128
mjprilliman merged 5 commits into
patchfrom
snow-slide-coeff

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

-Add option to change snow slide coefficient in snow model in SDK
-Previously fixed to 1.97
-Fixes NatLabRockies/SAM#1547

@mjprilliman mjprilliman added enhancement pv photovoltaic, pvsam, pvwatts labels Feb 13, 2024
@mjprilliman mjprilliman added this to the 2023 Release Patch 1 milestone Feb 13, 2024
@mjprilliman mjprilliman self-assigned this Feb 13, 2024

@janinefreeman janinefreeman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work, but the Ubuntu build is failing (I see your latest commit might fix that though) and I can't get the tests to build on my machine to run them right now (my problem, not a problem with this PR)...

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

This looks like it should work, but the Ubuntu build is failing (I see your latest commit might fix that though) and I can't get the tests to build on my machine to run them right now (my problem, not a problem with this PR)...

The build failed in Windows as well, it just didn't show in the editor until I compiled. I updated it to have the default value in the function call rather than the blank space which should work, I'll let the tests build to see.

@mjprilliman mjprilliman merged commit 936dd95 into patch Feb 29, 2024
@mjprilliman mjprilliman deleted the snow-slide-coeff branch February 29, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAM Snow Model with Ground-Mount PV System

3 participants