Fix reporting of ground reflected rear irradiance gains in loss diagram#1125
Merged
Conversation
cpaulgilman
approved these changes
Jan 26, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now.
Some test comparisons based on Detailed PV / No Financial with bifacial module enabled, "Ground reflected to rear" reported on Losses tab:
SAM 2022.11.21: 6.181%
SAM 2023.12.17: 0.142%
SAM Open Source ssc-1124-fix: 6.399%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Individual components of bifacial rear irradiance gain in PV loss diagram were reporting wrong values due to clear sky calls of function calculating rear irradiance being made after original call.
-Update variable declarations to not overwrite bifacial irradiance outputs
-No changes to bifacial energy calculations, only loss diagram outputs