Fixes to availability losses#1093
Merged
Merged
Conversation
Collaborator
UI fixes are in NatLabRockies/SAM#1580. |
mjprilliman
approved these changes
Nov 16, 2023
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good when testing in PV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the setup of availability losses to properly determine the loss timestep. It updates the error messages to give more helpful information (and fixes a mislabeled error message in hcpv). It also updates the battery tests for these losses, which had the loss enabled when it wasn't being used. Fixes #181 . This does need one UI update to the widget in the wind model in the SAM repo, which I will wait until @cpaulgilman is finished doing his UI review to complete.