Skip to content

Sam 313 reopt v3 for resilience#1078

Merged
brtietz merged 12 commits into
developfrom
sam_313_reopt_v3_for_resilience
Nov 10, 2023
Merged

Sam 313 reopt v3 for resilience#1078
brtietz merged 12 commits into
developfrom
sam_313_reopt_v3_for_resilience

Conversation

@brtietz

@brtietz brtietz commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

Several changes to the REopt interface including:

Pairs with SAM PR NatLabRockies/SAM#1527, see that PR for test instructions.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good in SSC.

May need to revise example code in PySAM documentation: https://nrel-pysam.readthedocs.io/en/main/examples.html?highlight=reopt#generate-inputs-for-a-reopt-api-call

@dguittet dguittet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm also

@brtietz brtietz merged commit 916dd29 into develop Nov 10, 2023
@brtietz brtietz deleted the sam_313_reopt_v3_for_resilience branch December 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants