Allow for custom tracker rotation angles timeseries input for subarrays#1071
Merged
Conversation
running through sdk
Collaborator
Author
|
LK file and dll for SDKtool testing. |
cpaulgilman
requested changes
Oct 26, 2023
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Functionality looks good.
SDKtool scripts to test importing custom tracker rotation and cell temp arrays with simulation error checks: custom-tilt-temp-sdktool-scripts.zip
- For cell temperature input, please change "measured" in all variable names, labels, and error messages to "custom" to be consistent with rotation angle input. Suggested variable names:
subarray1_use_custom_cell_temp
subarray1_custom_cell_temp_array
-
Please fix error message for temperature array with invalid value (should not refer to tilt angle and need space between "1" and "custom": "Error: exec fail(pvsamv1): Subarray 1custom tilt angles cannot be greater than 100degC. time -1.000000"
-
Please fix error message for custom rotation angle to refer to "custom tracker rotation angles" instead of "custom tilt angles".
This was referenced Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Add SDK inputs for using custom rotation angle inputs, optional timeseries arrays
-Set tracking mode to single-axis when using this feature for the 4 subarrays
-Also update use measured module temperature feature to be unique across each subarray.
-Add unit tests
@cpaulgilman This is an SDK only feature for now. Let me know how I can help with documentation. I'm hoping to build a PySAM example notebook for this feature for a future PySAM release.
-Closes (NatLabRockies/SAM#850), updates NatLabRockies/SAM#106