Skip to content

Tidal timeseries model#1069

Merged
mjprilliman merged 8 commits into
developfrom
tidal-timeseries-model
Oct 24, 2023
Merged

Tidal timeseries model#1069
mjprilliman merged 8 commits into
developfrom
tidal-timeseries-model

Conversation

@mjprilliman

@mjprilliman mjprilliman commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

-Add tidal file reader module
-Add modeling of tidal energy output based on timeseries velocity data
-Add unit tests for cmod_mhk_tidal, tidal_file_reader
-Add LK functions for scanning tidal file library, viewing tidal velocity data in data viewer

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Oct 19, 2023
@mjprilliman mjprilliman self-assigned this Oct 19, 2023
cpaulgilman
cpaulgilman requested changes Oct 19, 2023
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use single /SAM Downloaded Weather File for downloaded solar, wind and marine energy files instead of separate folders.

Set default for tidal resource library selection to avoid pop-up error message.

Set default for tidal resource folder list to empty so "x" does not appear in list by default.

@cpaulgilman cpaulgilman mentioned this pull request Oct 19, 2023
Merged
13 tasks
@mjprilliman

mjprilliman commented Oct 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Use single /SAM Downloaded Weather File for downloaded solar, wind and marine energy files instead of separate folders.
-Updated locations, need to test.
Set default for tidal resource library selection to avoid pop-up error message.
-Fixed
Set default for tidal resource folder list to empty so "x" does not appear in list by default.
-Believe this was a callbacks issue (wrong UI form title in on_load) more than a defaults issue. Defaults manager for all library_folder_list variables is "x" when I checked in defaults manager

@mjprilliman mjprilliman merged commit 8c1c921 into develop Oct 24, 2023
@mjprilliman mjprilliman deleted the tidal-timeseries-model branch October 24, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

Assignees

@mjprilliman mjprilliman

Labels

added to release notes new feature

Projects

None yet

Milestone

SAM Fall 2023 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@mjprilliman @cpaulgilman