Skip to content

New Hybrid Configurations#1051

Merged
sjanzou merged 64 commits into
developfrom
hybrids
Sep 18, 2023
Merged

New Hybrid Configurations#1051
sjanzou merged 64 commits into
developfrom
hybrids

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

Defaults and UI for new hybrid configurations for Single Owner and Host Developer financial models:

PVWatts Wind Battery Hybrid

PVWatts Wind FuelCell Battery Hybrid

Photovoltaic Wind Battery Hybrid

Generic PVWatts Wind FuelCell Battery Hybrid

Goes with:

sjanzou and others added 30 commits April 17, 2023 05:12
Single compute module run in cmod_hybrid - expanding to multiple
Comment thread ssc/cmod_hybrid.cpp Outdated
run grid

//Run utilityrate if applicable
run utilityrate

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Electricity purchases are not showing up in cash flow for PVWatts-Wind-Battery Single Owner, and maybe others. Unclear if this is the problem or if it is somewhere else. Host-developer looks ok.

SAM file to reproduce:
hybrids-electricity-purchases.zip

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Electricity purchases are not showing up in cash flow for PVWatts-Wind-Battery Single Owner, and maybe others. Unclear if this is the problem or if it is somewhere else. Host-developer looks ok.

SAM file to reproduce: hybrids-electricity-purchases.zip

Good catch - issue was that the metering option was set to net metering and would not bill for default configurations - metering option updated to buy all sell all like pv battery configuration and working per attached document.
GitHubPullRequestsssc_1051.docx

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjanzou would you mind doing a pass for comment cleanup on the hybrid cmod files? It's hard to tell which TODOs are still relevant and which are already done. Similarly some of the pseudocode could likely be deleted at this point.

Fix all warning messages on Windows build.

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code cleanup!

@brtietz

brtietz commented Sep 15, 2023

Copy link
Copy Markdown
Collaborator

I don't think this should block the merge, but recording issues here until we decide they go on the main GitHub pile. The two variables on the left here look the same to me:

image

Should the "power generated by renewable resource" be more analogous to the "Power produced by PV pre-curtailment" of the PV+Battery module?

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants