Skip to content

Throw an error if duplicate entries in the voltage table produce zero slope#1020

Merged
brtietz merged 2 commits into
patchfrom
ssc_1007_error_for_voltage_table_duplicates
May 4, 2023
Merged

Throw an error if duplicate entries in the voltage table produce zero slope#1020
brtietz merged 2 commits into
patchfrom
ssc_1007_error_for_voltage_table_duplicates

Conversation

@brtietz

@brtietz brtietz commented May 4, 2023

Copy link
Copy Markdown
Collaborator

Fixes #1007

Testing with the case in the issue should produce an error message, testing with the defaults should not.

@brtietz brtietz added the battery label May 4, 2023
@brtietz brtietz added this to the 2022.11.21 Patch 2 milestone May 4, 2023
@brtietz brtietz requested review from cpaulgilman and dguittet May 4, 2023 16:27
@brtietz brtietz self-assigned this May 4, 2023
@cpaulgilman

Copy link
Copy Markdown
Collaborator

Updated Help to explain that duplicate voltage values are not allowed in voltage table for Fall 2023 version.

@brtietz brtietz deleted the ssc_1007_error_for_voltage_table_duplicates branch December 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Voltage Table can improperly calculate current when two depths of discharge have the same value

3 participants