Skip to content

Conversation

@ckirney
Copy link
Collaborator

@ckirney ckirney commented Aug 6, 2025

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

weilixu and others added 30 commits February 26, 2025 12:09
`setRatedCoolingCOP` was deprecated in OS v2.9.0 and replaced with `setGrossRatedCoolingCOP`
Add version check for VRF cooling COP setter
Update DOE ref chiller efficiencies
replace 'exterior_lighting_zone_number' with 'lighting_zone'
The 90.1-2004 and later vintages of 90.1 now have a different data schema from other standard templates. Update the code to account for the different data schema. Update to the tests to account for object renaming.
Building Energy Standards Exterior Lighting Data Update
ckirney and others added 29 commits July 15, 2025 16:51
Set constant values for heating and cooling schedules. The original values were from end use data, which was an average. It appears some stores had setbacks and most didn't, and the results is slight (1C) setbacks overnight. That causes issues in parametric schedules and sawtooth schedules. This commit changes the values to a constant average temperature.
…of 1 kW if sizing run foils and rerun sizing run.
…bdirectory as try_sizing_run method argument.
…ry_sizing_run method to include additional argument from master.
add defrost and dripdown schedule variation to refrigerated cases and walkins. Iterate the start hour over the cases and walkins added to the model. Add fields for defrosts per day and duration to the typical cases and walkins data. Assumptions for these values are placeholder values for now, based on prior values and a quick internet search.

The purpose for adding variation is so that all the schedules aren't synced and cause a spiky profile in demand.
- for cases, default to one 45 minute defrost cycle per day followed by a 5 minute dripdown
- for walkins, default to two 45 minute defrost cycles per day followed by a 5 minute dripdown
- add logic to avoid adding defrost and dripdown schedules if offcycle
- add logic to handle dripdowns exceeding the hour after a defrost
- update cases and walkins defrost and dripdown values from the ORNL database
Add defrost and dripdown schedule variation to refrigeration
@ckirney ckirney merged commit 3d9edd7 into nrcan Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants