-
Notifications
You must be signed in to change notification settings - Fork 66
Nrcan merge master #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Nrcan merge master #1980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`setRatedCoolingCOP` was deprecated in OS v2.9.0 and replaced with `setGrossRatedCoolingCOP`
Add version check for VRF cooling COP setter
Exterior lighting module
Update DOE ref chiller efficiencies
replace 'exterior_lighting_zone_number' with 'lighting_zone'
The 90.1-2004 and later vintages of 90.1 now have a different data schema from other standard templates. Update the code to account for the different data schema. Update to the tests to account for object renaming.
… to be created as a regular construction
Building Energy Standards Exterior Lighting Data Update
Set constant values for heating and cooling schedules. The original values were from end use data, which was an average. It appears some stores had setbacks and most didn't, and the results is slight (1C) setbacks overnight. That causes issues in parametric schedules and sawtooth schedules. This commit changes the values to a constant average temperature.
Landan t/case credit fix
…of 1 kW if sizing run foils and rerun sizing run.
…in NECB2011 and BTAPPRE1980 classes.
…bdirectory as try_sizing_run method argument.
…ry_sizing_run method to include additional argument from master.
Supermarket Thermostat Schedules
add defrost and dripdown schedule variation to refrigerated cases and walkins. Iterate the start hour over the cases and walkins added to the model. Add fields for defrosts per day and duration to the typical cases and walkins data. Assumptions for these values are placeholder values for now, based on prior values and a quick internet search. The purpose for adding variation is so that all the schedules aren't synced and cause a spiky profile in demand.
…_auto_zoning method.
…odelling each floor explicitly.
- for cases, default to one 45 minute defrost cycle per day followed by a 5 minute dripdown - for walkins, default to two 45 minute defrost cycles per day followed by a 5 minute dripdown - add logic to avoid adding defrost and dripdown schedules if offcycle - add logic to handle dripdowns exceeding the hour after a defrost - update cases and walkins defrost and dripdown values from the ORNL database
Add defrost and dripdown schedule variation to refrigeration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)requirestatements, ensure these are in core ruby or add to the gemspecReview Checklist
This will not be exhaustively relevant to every PR.