Remove fuelcell and battery outputs from cases without those systems#570
Merged
Conversation
enabled in the case
brtietz
requested changes
Apr 29, 2021
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for cleaning all of this up! I had one request on the replacement options, since I consider it easier to handle zeroes than nans when comparing the "no replacements" cases to other cases. Other than that looks good!
cpaulgilman
requested changes
Apr 30, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me, and agree with Brian's suggestions.
Since this touches cmod_singleowner,cpp, could you fix the group name for issuance_of_equity in the inputs var table? It looks like someone accidentally pasted into it. It should be "Cash Flow Total and Returns" instead of "TCash Flow Total and Returnsotal Cash Flow and Return":
group label in singleowner
brtietz
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Added assignment checks to only output fuel cell and battery OandM and replacement cost outputs when there is a fuelcell or battery, respectively
-Removed battery efficiency, AC loss, and DC loss for cases without a battery
-Closes NatLabRockies/SAM#510
-Closes NatLabRockies/SAM#448