ensure num_tiers is enforced for the first tier of each month#560
Merged
Conversation
cpaulgilman
approved these changes
Apr 14, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I tried to make the error messages when there is a discrepancy between weekday/weekend schedules and demand or energy rate tables a little easier to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves NatLabRockies/SAM#563 - the variable to set the number of tiers in a month was being reset for each period, rather than enforcing the number of tiers in the first period of the month. This produces an existing error message in the SAM file attached to the bug, and responds correctly to different months having different numbers of tiers.