Batt fixes#549
Merged
Merged
Conversation
This reverts commit 14767a6.
brtietz
requested changes
Mar 11, 2021
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall, but I have one question about edge cases in lib_battery_lifetime_nmc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the NMC model, relying on differences between lifetime indices to compute whether a full day has elapsed or not had difficulties when using different time steps. That issue occurred when towards the end of the day, the hourly battery would "finish" its day, then get switched over to a smaller timestep (1 min) and would run into needing to "finish" its day again-- resulting in problems. The previous fix was to make the index when the day "finishes" equal to
lifetimeIndex % ts_per_day == ts_per_day - (size_t)(1. / params->dt_hr)so that the repetition wouldn't happen.The fix here explicitly calculates elapsed day as
fabs(state->nmc_li_neg->cum_dt - 1.) < 1e-7.Also, reduce the run time of
calculate_max_discharge_wfxns.