Skip to content

Adaptive timestep#545

Merged
dguittet merged 7 commits into
patchfrom
adaptive_timestep
Mar 3, 2021
Merged

Adaptive timestep#545
dguittet merged 7 commits into
patchfrom
adaptive_timestep

Conversation

@dguittet

@dguittet dguittet commented Feb 27, 2021

Copy link
Copy Markdown
Collaborator

Fix issues in adaptive timestepping of the battery detailed in #544 by:

  • adding lifetime_param's dt_hr to the copy assignment operator
  • adjust state->last_idx for the new dt_hr
  • fix battery_t copy constructor and delete copy assignment operator
  • add tolerance to rainflow counter
  • update cycle tests and cmod tests

@dguittet dguittet requested a review from mjprilliman March 1, 2021 14:55
@dguittet dguittet added this to the 2020.11.29 Patch 2 milestone Mar 1, 2021
@dguittet dguittet merged commit 7d8f2c3 into patch Mar 3, 2021
@dguittet dguittet deleted the adaptive_timestep branch March 3, 2021 18:45
@brtietz brtietz mentioned this pull request Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjprilliman mjprilliman mjprilliman approved these changes

Assignees

No one assigned

Labels

battery

Projects

None yet

Milestone

2020.11.29 Patch 2

Development

Successfully merging this pull request may close these issues.

2 participants

@dguittet @mjprilliman