@mjprilliman,

1. Why are there so many CSP file changes in this pull request?
2. What exactly should we be testing? Do you have a SAM file or steps to test?

@mjprilliman,

1. Why are there so many CSP file changes in this pull request?
2. What exactly should we be testing? Do you have a SAM file or steps to test?

1. I built SAM_api in the build process so those api updates must be from previous work that was not updated in the SAM_api
2. I will add detailed test instructions and files here

Test instructions:
-Download weather files in attached zip file to dedicated folder (nothing else in folder)

-Open a Marine Wave - LCOE Calculator case
-On Wave Resource page, select Time Series option
-Click 'Create JPD from time series file(s) button'
-Follow prompts to select folder containing only downloaded wave files, then file for output JPD file
-Check that file is saved correctly and appears in 'Frequency of Occurence' library with naming convention 'latX_lonX_startyear_endyear'

Additional test:
-Run wave download tool from button
-Download file(s) (must have API calls set up to work from built version)
-Ensure that yesno prompts user to run JPD file generator, same steps as previous test

ME_humboldt_bay.zip

The functionality here is generally good. A couple of comments to improve the user experience:

1. When I try to download files for all years, if the API call fails, I get a "Weather file not available" message for each file, so I have to click OK a bunch of times. I would expect the download to stop if the API call fails instead of trying for each file. For example, if the API returns "API_KEY_MISSING" the download process should stop after displaying the first "Weather file not available" message.

2. I think SAM is creating a "SAM Downloaded Device Files" folder in my user folder. Should that be "SAM Downloaded Wave Resource Files" instead?

3. The "Choose folder" dialog title might be more informative as "Choose folder containing single-year wave resource files."

4. Please change the "Save MultiYear JPD File as" dialog title to "Save multi-year JPD file as" and the save as type from "JPD files" to "JPD File".

5. Please change the message text "A JPD file of the time series wave resource data has been generated and can be found on the Frequency of Occurence tab" to "Multi-year JPD file saved.\nTo use the file, switch from the Frequency of Occurrence option to Time Series, and choose " + jpd_name_parameter + " from the library.", where jpd_name_parameter is the name listed in the library. Because the library does not list the file name, it was hard for me to figure out what to choose to get the multi-year JPD.

6. The Average Power Flux column for the multi-year JPD file shows "nan" in the library list.

7, Each time I create a multi-year JPD file. SAM adds the weather file folder to the Frequency of Occurrence library folders even if it is already there. In this case, the ME_humboldt_bay folder is listed twice:

@cpaulgilman Can you re-review for user experience when you get the chance? I tried to address all your points in your first review.

Hi Matt,

I tested running the make JPD file feature by following the prompt after downloading single year files, and get this error:

I get a similar error after clicking Creaste JPD from time series weather file(s) as a separate step.

Hi Matt,

I tested running the make JPD file feature by following the prompt after downloading single year files, and get this error:

I get a similar error after clicking Creaste JPD from time series weather file(s) as a separate step.

@cpaulgilman did you rebuild with the latest commits pulled into the branch? I'm not able to replicate that error. Every other branch (ssc, lk, wex) should be patch.