Fix RE-only scenario in Value of RE macro#982
Merged
Conversation
* Set battery capacity to zero instead of using en_batt to disable battery. * Add user feedback about disabling battery.
brtietz
pushed a commit
that referenced
this pull request
Mar 31, 2022
* Testing Puerto Rico Wizard setup * First iteration of Puerto Rico mini grid wizard * Update project file and script * Updates based on meeting * LCOE versus unmet load percentage added to wizard * Add total cost per participant output plots to wizard and parametrics table * Update Puerto Rico Mini Grid wizard output plots per email from Nate * parametricviewer import function still failing. * Update Puerto Rico Mini Grid wizard per 3/8/2022 meeting * Fix PuertoRicoWeatherDir to remove extra forward slash * Updates so that parametricviewer export and import work consistently * Fix windows build issue using Item(ndx) rather than At(ndx) in Simulation::ListAllOutputs * Fix run time issue with fcall_parametric_import and update wizard and template file * Update wizard and template file for latest sizing algorithm * Puerto Rico Mini Grid wizard now working and ready for review * Code cleanup * Clean up mini-grid wizard Remove "Puerto Rico" from file names and descriptive text. Edit wizard text for clarity and remove milisleep() pauses after msgbox(). Use consistent case for wizard LK script file names to clean up wizard list on Welcome page. * Fix input grid power target UI issues (#988) * Fix default value of `batt_target_power` very small number instead of zero. * Improve text description of grid power target and battery power target options. * Improve labels in monthly and time series data input windows. * Remove leading space from standalone battery input variable label * Fix RE-only scenario (#982) * Set battery capacity to zero instead of using en_batt to disable battery. * Add user feedback about disabling battery. * Get forecasts working for generic battery by running generic system with an 8760 production profile * clean up scripts for stand alone battery and defaults based on test results * update required defaults for fuel cell * Help revisions for "generation" vs "production" * Swap labels from production to generation as appropriate * Align widget with ones below to avoid overlap issues in Linux/Mac Co-authored-by: Steven Janzou <sjanzou@gmail.com> Co-authored-by: Steven Janzou <steve@janzouconsulting.com> Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
cpaulgilman
added a commit
that referenced
this pull request
May 5, 2022
cpaulgilman
added a commit
that referenced
this pull request
May 23, 2022
* Initial cashflow to Excel fixes for SO and CS * Copy Value of RE macro from com to res (#982) * Updates to merchant, CS, SO spreadsheets Remove debt size limit option inputs in UI except for single owner * Finish fixes new to all spreadsheets * CS and SO updates to cashflow * Update to AEPF and LPF, tweaks to other models * Sale leaseback done * Finish changes, ready for testing * Fix bad sum() and add pbi available for debt service * Final fixes * Update test_results_win64.csv * Address Brian's comments * Remove redundant check for Host Developer to display cf_utility_bill * Fix missing parentheses from is_fom_fin(). * Fix logic in set_annual_values to not export cf_ppa_price for BTM models. * Fix broken export_config that was from patch * Updated windows results to prevent any Gtihub Action issues * Fixes for Steve PR review Fix Host Developer ppa_revenue, ppa_price Change label in Excel to "Minimum debt service coverage ratio" (add "Minimum"). Fix Excel working capital reserve funding and check all other workbooks. * Partnership flip and LCOS fixes Fix partnership flip tax investor operating cash distributions double-counting pre/post flip. Fix LCOS send annual values for all FOM configs with battery. * Updated export_config build for pull request 1044 * Fix SO analysis period IRR formula Co-authored-by: Steven Janzou <sjanzou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Set battery capacity to zero instead of using en_batt to disable battery.
Add user feedback about disabling battery.
Fixes #970
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.