Skip to content

Geothermal Drilling cost curve updates#910

Closed
mjprilliman wants to merge 13 commits into
developfrom
geothermal_cost_updates
Closed

Geothermal Drilling cost curve updates#910
mjprilliman wants to merge 13 commits into
developfrom
geothermal_cost_updates

Conversation

@mjprilliman

@mjprilliman mjprilliman commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

Description

-Update drilling and injection cost curves to be based off scenario (4 options), well diameter (2 options), and well type (2 options)
-Add plot showing where along the cost curve scenarios the selection lies
-interface redesign

mjprilliman and others added 13 commits December 9, 2021 16:29
@mjprilliman
Updated drilling production and injection cost curves
fd48a05
@mjprilliman
Merge branch 'develop' into geothermal_cost_updates
5443a1e
@mjprilliman
Plot for drilling cost curve visualization
9494e5b
@mjprilliman
PPI cost input updates
9489eda
@mjprilliman
Updated labels on drilling cost plot
086f9e6
@mjprilliman
Add lifetime outputs to geothermal sLCOE and None models
2a9ed14
@mjprilliman
Merge branch 'patch' into geothermal_cost_updates
15ce913
@mjprilliman
UI design updates for drilling cost curves
3143a5f
@cpaulgilman
Clean up battery dispatch UI forms (#860)
10990af 
* Clean up battery dispatch UI forms

Click through battery dispatch forms for PV Battery, Generic Battery, Standalone Battery, and Fuel Cell and try all options to fix any problems with callbacks or messages for FOM (Single Owner) and BTM (Commercial)

* Change dispatch group labels to match radio button choices

* Fix dispatch choice callback error for non-fuel cell techs

* Clean up custom weather file inputs

* Fix variable group names and labels for variable browsers

* Fix labels for BTM peak shaving load growth

* Fix UI checks on fuel cell and battery manual dispatch

Also, disable "charge battery from fuel cell" check boxes when battery is disabled.
ETES: remove tax incentive and switch financing debt mode (#900)
6a05056 
* remove tax incentive and switch financing debt mode

* update etes default capacity payment, ppa price, and debt terms

* update test results for new ETES defaults
Update csp finance defaults (#906)
1615d9e 
* update physical trough ppa defaults

* update mspt and empirical trough ppa defaults

* update msLF trough ppa defaults

* update DSLF trough ppa defaults

* update Generic CSP ppa defaults

* switch flip years to 9

* update test results for updated csp financial defaults
@mjprilliman
Merge branch 'patch' into geothermal_cost_updates
4b4ede7
@mjprilliman
Remove PPI from UI for geothermal patch changes, fix issues with
3952f76 
injection drilling cost plot
@mjprilliman mjprilliman added this to the 2021.12.02 Patch 1 milestone Jan 31, 2022
@mjprilliman mjprilliman self-assigned this Jan 31, 2022
@mjprilliman

mjprilliman commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator Author

@cpaulgilman I could use some interface design notes on this

@cpaulgilman

cpaulgilman commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

@mjprilliman This is pretty cool. Nice work! I can make couple of small tweaks to make the layout clearer if you don't mind.

A couple of questions:

  1. Do you have a preference for the "Update Plot" button vs automatically updating it based on on_change events for the cost curve, well type, and well diameter options? It seems like it would be best for the state of the plots to always match the state of the options and calculated dollar amounts. But maybe I'm missing a reason to have the user update the plot manually?

  2. This will need documentation. Do you have references with definitions of the baseline, intermediate, and ideal cost curves?

@mjprilliman

mjprilliman commented Feb 1, 2022

Copy link
Copy Markdown
Collaborator Author

@mjprilliman This is pretty cool. Nice work! I can make couple of small tweaks to make the layout clearer if you don't mind.

A couple of questions:

  1. Do you have a preference for the "Update Plot" button vs automatically updating it based on on_change events for the cost curve, well type, and well diameter options? It seems like it would be best for the state of the plots to always match the state of the options and calculated dollar amounts. But maybe I'm missing a reason to have the user update the plot manually?
  2. This will need documentation. Do you have references with definitions of the baseline, intermediate, and ideal cost curves?
  1. I think I like updating for any changes too and I don't see a reason not to so I will update that.
  2. I will get a reference from the people that worked on the curves.
    Also I seemed to have caused a configuration to crash so I will investigate that further. I believe it is coming from Geothermal LCOE or Geothermal None

@mjprilliman mjprilliman mentioned this pull request Feb 1, 2022
Merged
@mjprilliman

mjprilliman commented Feb 1, 2022

Copy link
Copy Markdown
Collaborator Author

Moved to https://github.com/NREL/SAM/pull/912/files

@mjprilliman mjprilliman closed this Feb 1, 2022
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2022
sjanzou added a commit that referenced this pull request Oct 27, 2022
@sjanzou
update cashflow line items for ssc #910
c8fd8f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman Awaiting requested review from cpaulgilman

Assignees

@mjprilliman mjprilliman

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Milestone

2021.12.02 Patch 1

Development

Successfully merging this pull request may close these issues.

2 participants

@mjprilliman @cpaulgilman