Clean up battery dispatch UI forms#860
Merged
Merged
Conversation
Click through battery dispatch forms for PV Battery, Generic Battery, Standalone Battery, and Fuel Cell and try all options to fix any problems with callbacks or messages for FOM (Single Owner) and BTM (Commercial)
mjprilliman
reviewed
Dec 22, 2021
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Just one quirk with the Fuel Cell Battery manual dispatch interactions I noticed. Sorry for the delay on this review
Collaborator
|
@cpaulgilman This can be merged |
Also, disable "charge battery from fuel cell" check boxes when battery is disabled.
tyneises
pushed a commit
that referenced
this pull request
Jan 28, 2022
* Clean up battery dispatch UI forms (#860) * Clean up battery dispatch UI forms Click through battery dispatch forms for PV Battery, Generic Battery, Standalone Battery, and Fuel Cell and try all options to fix any problems with callbacks or messages for FOM (Single Owner) and BTM (Commercial) * Change dispatch group labels to match radio button choices * Fix dispatch choice callback error for non-fuel cell techs * Clean up custom weather file inputs * Fix variable group names and labels for variable browsers * Fix labels for BTM peak shaving load growth * Fix UI checks on fuel cell and battery manual dispatch Also, disable "charge battery from fuel cell" check boxes when battery is disabled. * update physical trough ppa defaults * update mspt and empirical trough ppa defaults * ETES: remove tax incentive and switch financing debt mode (#900) * remove tax incentive and switch financing debt mode * update etes default capacity payment, ppa price, and debt terms * update test results for new ETES defaults * update msLF trough ppa defaults * update DSLF trough ppa defaults * update Generic CSP ppa defaults * switch flip years to 9 * update test results for updated csp financial defaults Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
cpaulgilman
added a commit
that referenced
this pull request
Feb 2, 2022
* Clean up battery dispatch UI forms (#860) * Clean up battery dispatch UI forms Click through battery dispatch forms for PV Battery, Generic Battery, Standalone Battery, and Fuel Cell and try all options to fix any problems with callbacks or messages for FOM (Single Owner) and BTM (Commercial) * Change dispatch group labels to match radio button choices * Fix dispatch choice callback error for non-fuel cell techs * Clean up custom weather file inputs * Fix variable group names and labels for variable browsers * Fix labels for BTM peak shaving load growth * Fix UI checks on fuel cell and battery manual dispatch Also, disable "charge battery from fuel cell" check boxes when battery is disabled. * ETES: remove tax incentive and switch financing debt mode (#900) * remove tax incentive and switch financing debt mode * update etes default capacity payment, ppa price, and debt terms * update test results for new ETES defaults * Update csp finance defaults (#906) * update physical trough ppa defaults * update mspt and empirical trough ppa defaults * update msLF trough ppa defaults * update DSLF trough ppa defaults * update Generic CSP ppa defaults * switch flip years to 9 * update test results for updated csp financial defaults * Check for non-zero sell rate for energy rate table on_change Co-authored-by: tyneises <ty.neises@nrel.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Click through all options on battery dispatch forms for PV Battery, Generic Battery, Standalone Battery, and Fuel Cell and fix any problems with callback errors, incorrectly enabled/disabled inputs, or UI messages for FOM (Single Owner) and BTM (Commercial)
Fixes #846
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.