Batt dispatch choice variables matching default page loads#855
Merged
Conversation
variable for all battery configs
cpaulgilman
requested changes
Dec 10, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
@mjprilliman This looks good and fixes #855, but I found the default value of ui_batt_life_model is incorrect for several configurations. I think the default value should be ui_batt_life_model=1 for all configurations because the default battery type is Li-ion NMC/Graphite.
I tested the following configurations, but the defaults manager shows others, such as Fuel Cell / Single Owner have the wrong default value for ui_batt_life_model
- PV Battery / Merchant
- Generic Battery / Leveraged Partnership Flip
- Generic Battery / All Equity Partnership Flip
- Generic Battery / Sale Leaseback
(matches batt_life_excl), test results were unchanged
cpaulgilman
approved these changes
Dec 13, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks for making those changes with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated all detailed battery dispatch pages to have the same UI choice, batt_dispatch_choice value sent to ssc, and batt_dispatch_excl variable for correct page load based on default choices.
Fixes #846
Type of change
Please delete options that are not relevant.