Skip to content

move critical load equations after load scaling#842

Merged
brtietz merged 1 commit into
patchfrom
fix_crit_load_scaling
Dec 6, 2021
Merged

move critical load equations after load scaling#842
brtietz merged 1 commit into
patchfrom
fix_crit_load_scaling

Conversation

@brtietz

@brtietz brtietz commented Dec 6, 2021

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Fixes an issue where the scaling factor for the main load wasn't applied to the critical load. Critical load is now calculated from the scaled load.

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • [ x] Any dependent changes have been merged and published in downstream modules
  • [ x] I have checked my code and corrected any misspellings

@brtietz brtietz added the bug label Dec 6, 2021
@brtietz brtietz added this to the SAM Fall 2021 Release Patch 1 milestone Dec 6, 2021
@brtietz brtietz self-assigned this Dec 6, 2021

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brtietz brtietz merged commit 0c2a0e6 into patch Dec 6, 2021
@brtietz brtietz deleted the fix_crit_load_scaling branch December 7, 2021 16:48
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants