Update tax rates and om pt 1#823
Merged
Merged
Conversation
added 5 commits
November 30, 2021 16:28
…_rates_and_om_pt_1
added 2 commits
November 30, 2021 18:00
…_rates_and_om_pt_1
…this and recent changes from develop
cpaulgilman
requested changes
Dec 1, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Should Solar Water Heating / Residential federal tax rate be 15 instead of 21?
added 9 commits
December 1, 2021 09:54
…_rates_and_om_pt_1
…_rates_and_om_pt_1
…_rates_and_om_pt_1
Collaborator
Author
|
@cpaulgilman I just noticed a number of configurations (mostly behind the meter battery configs) have a 0% sales tax rate based on a commit you did in Feb 2020 (6e7c3ae) was that intentional? Most of the cost models list a sales tax term. |
Collaborator
|
Looks good to me now. |
cpaulgilman
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description