Don't check for Automated dispatch / ppa_soln_mode in Host Developer battery configs#821
Merged
Conversation
Developer battery configs
brtietz
approved these changes
Nov 30, 2021
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Fixes the problem that was reported, but I'm a little confused about the naming of the on_load function.
| // Any updates should be made to both forms. | ||
|
|
||
| on_load{'Financial Solution Mode Single Owner'} = define() | ||
| on_load{'Financial Solution Mode Flip Leaseback'} = define() |
Collaborator
There was a problem hiding this comment.
I'm a little confused by the name change here - should this match the top of the file?
Collaborator
Author
There was a problem hiding this comment.
You are correct this was changed on develop when it should not have been
mjprilliman
commented
Nov 30, 2021
Comment on lines
-575
to
-578
| elseif( financing() == 'Community Solar' ) | ||
| { | ||
| txt += 'Set PPA price or IRR target to zero if project only earns revenue from subscription payments on the Community Solar page.'; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This should not have been changed on develop
| // Any updates should be made to both forms. | ||
|
|
||
| on_load{'Financial Solution Mode Single Owner'} = define() | ||
| on_load{'Financial Solution Mode Flip Leaseback'} = define() |
Collaborator
Author
There was a problem hiding this comment.
You are correct this was changed on develop when it should not have been
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a check for Host Developer financing configs on the Revenue page to not check for the interaction between automated dispatch and ppa_soln_mode