Battery UI fixes#806
Conversation
Smoothing; disable minimum charge state input for standalone battery
cpaulgilman
left a comment
There was a problem hiding this comment.
I revised the UI message text and set them up to display on_change and on_load.
I'm getting callback errors "attempting to set 'batt_C_rate' (number) to " and sometimes a crash when I change battery type and choose replace defaults option for LFP/Graphite, LMO/LTO, Lead Acid...
This is handled in #805
| value('LeadAcid_tn',cell_params.leadacid_tn); | ||
| } | ||
|
|
||
| if (cell_params.voltage_choice == 0) { |
There was a problem hiding this comment.
This if statement needs to be reinstated. The JSON files do not contain both voltage table data and electrochemical data.
Fix line spacing in msgbox() text. Remove disable batt_minimum_modetime for standalone battery per #798 (comment) Use same check_auto_ppa() function for standalone and non-standalone FOM battery.
cpaulgilman
left a comment
There was a problem hiding this comment.
Looks good after my latest commit to re-enable minimum time at charge state per @brtietz comment, fixes to use consistent specify ppa price/irr messages for standalone and non-standalone FOM batteries, and minor line spacing in message boxes.
|
Test results were the same outside of ETES (is there variation in the optimizer?). Merging this PR. |
Description
Fixes #798
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.