Warning and PPA solution mode change when Specify IRR target is selected with Automated Dispatch#805
Merged
Merged
Conversation
chosen with Specify IRR target
cpaulgilman
approved these changes
Nov 28, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
I revised text on this, and removed the automatic setting of PPA solution mode to Specify PPA price to encourage the user to actively set the PPA price.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automated dispatch does not consider ppa_soln_mode when running the dispatch algorithm, so the algorithm can use the PPA price specified in ppa_price_input even when that input is disabled and not used in the rest of the code. Temporary workaround is to give a msgbox warning when this combination of input selections occurs before setting the ppa_soln_mode to Specify PPA price when Automated dispatch is selected.
See #NatLabRockies/ssc#666
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.