Skip to content

Warning and PPA solution mode change when Specify IRR target is selected with Automated Dispatch#805

Merged
mjprilliman merged 4 commits into
developfrom
batt_auto_dispatch_irr_target
Nov 29, 2021
Merged

Warning and PPA solution mode change when Specify IRR target is selected with Automated Dispatch#805
mjprilliman merged 4 commits into
developfrom
batt_auto_dispatch_irr_target

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

Automated dispatch does not consider ppa_soln_mode when running the dispatch algorithm, so the algorithm can use the PPA price specified in ppa_price_input even when that input is disabled and not used in the rest of the code. Temporary workaround is to give a msgbox warning when this combination of input selections occurs before setting the ppa_soln_mode to Specify PPA price when Automated dispatch is selected.

See #NatLabRockies/ssc#666

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2021 Release milestone Nov 24, 2021
@mjprilliman mjprilliman self-assigned this Nov 24, 2021
cpaulgilman added a commit that referenced this pull request Nov 28, 2021
This is handled in #805

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revised text on this, and removed the automatic setting of PPA solution mode to Specify PPA price to encourage the user to actively set the PPA price.

@mjprilliman mjprilliman merged commit 9e54c1a into develop Nov 29, 2021
@mjprilliman mjprilliman deleted the batt_auto_dispatch_irr_target branch November 29, 2021 21:14
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants