Skip to content

PV Default updates#793

Merged
mjprilliman merged 32 commits into
developfrom
pv_defaults_updates
Nov 24, 2021
Merged

PV Default updates#793
mjprilliman merged 32 commits into
developfrom
pv_defaults_updates

Conversation

@mjprilliman

@mjprilliman mjprilliman commented Nov 22, 2021

Copy link
Copy Markdown
Collaborator

Description

Update default values for PV Systems based on latest ATB spreadsheet. Utility-scale PV was modeled as single axis tracking system in the ATB so the default was modified for PV and PVWatts. The DC - AC ratios were adjusted in PVWatts to the latest benchmark report value of 1.15 (from 1.2). Test results were updated with new default values.

Fixes #792

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added the pv pvsam1, pvwatts, hcpv label Nov 22, 2021
@mjprilliman mjprilliman added this to the SAM Fall 2021 Release milestone Nov 22, 2021
@mjprilliman mjprilliman self-assigned this Nov 22, 2021
@janinefreeman

Copy link
Copy Markdown
Collaborator

Reviewing these now, you may already be planning to build SAM_api before merging but I think this is one of those times where we need to if I understood correctly.

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

@janinefreeman I just pushed a commit for wind system size and capex updates. You had a separate testing item for wind costs outside of ATB updates, but I updated these values using ATB utility wind and offshore wind values so not sure if this is what was expected. Happy to revert the commit if not. @brtietz already updated the capacity O&M values to match that of the ATB.

@janinefreeman

Copy link
Copy Markdown
Collaborator

That sounds perfect. As more defaults align with the ATB, we have fewer that need to be updated separately :)

janinefreeman and others added 19 commits November 23, 2021 09:55

@janinefreeman janinefreeman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending updates to test script results, I would say this looks reasonable so far. @mjprilliman I'm done with my updates, let me know when you'd like me to review again

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Changes to make the ppa prices the default for electricity purchases caused the generic battery and standalone battery configs to fail because they were still on 'Specify IRR target' mode. Determining reasonable PPA prices and re-running the test script before merging.

@mjprilliman mjprilliman merged commit 6d296bf into develop Nov 24, 2021
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
@mjprilliman mjprilliman deleted the pv_defaults_updates branch December 9, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release pv pvsam1, pvwatts, hcpv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RC PV Defaults Need Updating

4 participants