add alternative battery surface area calculatons#789
Merged
Conversation
… utility scale batteries have sufficient surface area to return to their ambient temperature when not running
dguittet
approved these changes
Nov 19, 2021
mjprilliman
approved these changes
Nov 19, 2021
| INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
| ARE DISCLAIMED.IN NO EVENT SHALL THE COPYRIGHT HOLDER, CONTRIBUTORS, UNITED STATES GOVERNMENT OR UNITED STATES | ||
| DEPARTMENT OF ENERGY, NOR ANY OF THEIR EMPLOYEES, BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, | ||
| OR CONSEQUENTIAL DAMAGES(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; |
Collaborator
There was a problem hiding this comment.
Is this file supposed to differ from develop on this PR?
Collaborator
Author
There was a problem hiding this comment.
Yes, see Darice's email about the version on develop breaking the Mac build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with the increased heat transfer coefficient, the utility scale batteries still do not return to their nominal operating temperature when they are not running. Add a function that allows users to specify the surface area and capacity of a single battery "module" - which represents how utility scale batteries are often installed. Pick defaults for this value from the HOPP project.
Residential and third party still use the old cubic formulation by default, where as commercial and utility scale batteries use the new modular formulation.
Updates to the values in test_results_win64 will occur after #786 is merged.