Skip to content

Tidal devices updates#740

Merged
mjprilliman merged 10 commits into
developfrom
tidal_devices_updates
Nov 16, 2021
Merged

Tidal devices updates#740
mjprilliman merged 10 commits into
developfrom
tidal_devices_updates

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

-Added second default option for tidal devices
-Can import power curve from csv or clipboard
-No writing to library currently

@mjprilliman mjprilliman added this to the SAM Fall 2021 Release milestone Nov 9, 2021
@mjprilliman mjprilliman self-assigned this Nov 9, 2021
@cpaulgilman

Copy link
Copy Markdown
Collaborator

Should the table be disabled for the "Choose tidal converter from library" option? Otherwise, it's not clear what happens when I import device data from a file (while in library mode): The data in the table updates to the data from the file, but if I reload the page, it reverts to the library selection. The disadvantage of disabling the table is that you can't export data from the library to a file to modify.

And, a separate issue/question:

If I switch from RM1 to RM2, I get a "Size of Power Curve is not equal to Tidal Resource" error. Does the device power curve have to have the same number of bins as the resource table? I thought the model would interpolate if the tables don't match.

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Should the table be disabled for the "Choose tidal converter from library" option? Otherwise, it's not clear what happens when I import device data from a file (while in library mode): The data in the table updates to the data from the file, but if I reload the page, it reverts to the library selection. The disadvantage of disabling the table is that you can't export data from the library to a file to modify.

And, a separate issue/question:

If I switch from RM1 to RM2, I get a "Size of Power Curve is not equal to Tidal Resource" error. Does the device power curve have to have the same number of bins as the resource table? I thought the model would interpolate if the tables don't match.

On the first question, I wasn't sure if we should disable the ability to modify when in library mode or not. The wave model has the same thing where users can change values in the matrix but reloading the page restores the library value. I'm open to disabling the ability to edit when in library mode but I'll test to see if I can retain the changes on page load first.

On the second question, at this point no work has been done to interpolate between differently sized arrays for resource and power definitions. We have been leaving it to the user to make sure the lengths of these arrays match. I suppose that could change in the future.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from RM1 to RM2 results in a simulation error. Should the device power curve be modified to have the same number of rows as the default resource data?

image

@mjprilliman mjprilliman merged commit da4314f into develop Nov 16, 2021
@mjprilliman mjprilliman deleted the tidal_devices_updates branch November 16, 2021 03:48
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants