Skip to content

Dispatch for grid outage and new min SOC#722

Closed
brtietz wants to merge 18 commits into
developfrom
dispatch_for_grid_outage
Closed

Dispatch for grid outage and new min SOC#722
brtietz wants to merge 18 commits into
developfrom
dispatch_for_grid_outage

Conversation

@brtietz

@brtietz brtietz commented Oct 28, 2021

Copy link
Copy Markdown
Collaborator

Pairs with SSC PR NatLabRockies/ssc#632 - pull dispatch_for_grid_outage from ssc to test

  • Adds a minimum outage SOC variable to allow for non-zero SOCs during outage - this appears on the behind the meter UI pages below the existing SOC. Crit load must be specified to change this variable
  • Updates the nominal SOC to 30% for behind the meter cases
  • Runs the API autogen code for these changes and some changes from develop
  • Updates the Windows test results for all of the above

@brtietz brtietz added this to the SAM Fall 2021 Release milestone Oct 28, 2021
@brtietz brtietz changed the title Dispatch for grid outage Dispatch for grid outage and new min SOC Oct 28, 2021
@brtietz brtietz mentioned this pull request Oct 28, 2021
Closed
Brian Mirletz and others added 3 commits October 28, 2021 15:33
fix build issue by adding missing file
e23062e
Merge branch 'develop' of https://github.com/NREL/SAM into dispatch_f…
867ce31 
…or_grid_outage
@cpaulgilman
UI tweaks for outage minimum SOC
90a5f03 
* Revise text in messages.

* Wrap and top-align labels

* Assign group name to new variable so it appears with other dispatch inputs in variable lists.

* Use more spacing between widgets to minimize risk of overlap in non-Windows operating systems
cpaulgilman
cpaulgilman approved these changes Nov 2, 2021
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after my tweaks.

@brtietz

brtietz commented Nov 3, 2021

Copy link
Copy Markdown
Collaborator Author

Test failure was due to an issue on develop which was fixed here: b143074
Given how quickly we're burning through Travis credits this week, I'm not going to re-run this unless there are further changes to the branch.

@brtietz

brtietz commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator Author

Merged in e9d9579

@brtietz brtietz closed this Nov 8, 2021
@brtietz brtietz deleted the dispatch_for_grid_outage branch November 11, 2021 16:51
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

@dguittet dguittet Awaiting requested review from dguittet

Assignees

No one assigned

Labels

added to release notes PR and/or issue has been added to release notes for a public release battery enhancement

Projects

None yet

Milestone

SAM Fall 2021 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@brtietz @cpaulgilman