Fix battery sizing behavior when switching between kWh and h definitions#720
Conversation
updated before simulation
variable to store kWh
brtietz
left a comment
There was a problem hiding this comment.
Converting to a calculated variable works great and the issue in the parametrics interface has been fixed, thank you!
I worry about the large number of defaults that are being set to 0 or nan. The GUI doesn't mind, because the calculated values overwrite them immediately, but many of these are exported to the PySAM/API json (located in api/api_autogen/library/defaults), and I worry this could cause problems with those defaults. Is it possible to add the batt_bank_size_ui variable without all of these changes?
I believe it should be. There was an error when I first set the batt_bank_size_ui variable and ran the test script and that probably overwrote far more than what I was intending. I will take another look. |
updated defaults with batt_bank_size_ui matching batt_bank_size
brtietz
left a comment
There was a problem hiding this comment.
Looks great, thank you!
-Make batt_bank_size a calculated variable based on either kWh UI entry or batt_bank_duration * batt_bank_power
-Update file defaults with new batt_bank_size_ui variable for displaying kWh definition in UI
-Closes #716