Batt_dispatch_choice update to switch choice to Automated for FOM#690
Closed
mjprilliman wants to merge 1 commit into
Closed
Batt_dispatch_choice update to switch choice to Automated for FOM#690mjprilliman wants to merge 1 commit into
mjprilliman wants to merge 1 commit into
Conversation
with dispatch choice variable not updating
Collaborator
|
It looks like https://github.com/NREL/SAM/pull/712/files has the same fix as this branch - should this be closed once that one is merged? |
Collaborator
Author
I would say yes. I did not realize I never merged this in but yes I will close |
Collaborator
Author
|
Issue solve with PR #712, closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Switching batt_dispatch_choice_ui radio buttons from another option to Automated does not update batt_dispatch_choice as it should.
-Battery model is still running prior selection for the dispatch option
-This fix should fix that behavior