Wave model time series#645
Merged
Merged
Conversation
wave resource library working again
UI bugs to work out)
decisions on what to do with header)
debugging API calls from SAM (not clear any urls are getting data outputs)
Dialog box appearance
libraries, removed use_specific_wf_wave
options for API calls in favor of detailed dialog box
library, hid API feature until complete
variables, fixed pop up notice label
cpaulgilman
approved these changes
Jul 1, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Need to delete file_name from defaults for ME Wave / None configuration.
Do we need both wave_data_file_ts and wave_resource_filename_ts for the time series option? Same question for wave_data_file_freq and wave_resource_filename for the frequency option.
Collaborator
Author
I suppose not. the vars with filename are what go into the compute modules. So I think I will keep those to be consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-New UI interface with time series data
-Significant_wave_height, energy_period arrays used to calculate wave energy converter performance
-API calls hidden, still in development
-New exclusive_var used to specify whether probability distribution or time series data are used in calculations
-New 3-hour time series outputs
-New wave resource time series data library with defaults matching locations of JPD file locations
-New function in library.cpp for handling changes to time series library