Skip to content

Fixed batt dispatch loaded page to Manual dispatch for FOM systems#644

Merged
mjprilliman merged 3 commits into
developfrom
batt_dispatch_defaults
Jul 1, 2021
Merged

Fixed batt dispatch loaded page to Manual dispatch for FOM systems#644
mjprilliman merged 3 commits into
developfrom
batt_dispatch_defaults

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

-Fixes page misalignment with radio choice selection on new case load-in for FOM battery systems
-Fixed fuel cell dispatch behavior where inputs were visible and enabled even when en_batt == 0

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Fuel Cell "Dispatch" page, can you move the FOM/BTM Storage Dispatch Options UI form directly below the Fuel Cell Dispatch form so that the battery forms are below the options? That will avoid the options jumping around as you change them.

There are large blocks of commented-out code in the UI callbacks for these forms. Can they be deleted?

Battery Dispatch Front of Meter
Battery Dispatch Manual
Battery Dispatch Options BTM

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

So I've been confused with these pages as even when the Manual Dispatch choice isn't selected for the battery, the fuel cell dispatch is still handled from this page so it must still be visible. So, moving the manual dispatch form to the bottom of the page would require some sort of exclusive_footer tag to be developed similar to exclusive_header as the page would always be underneath switching battery dispatch cases.

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Right. That is confusing. I think I like it better now with the fuel cell operation and storage dispatch options at the top. We can improve on this later if we have a fuel cell project to support that work.

@mjprilliman mjprilliman merged commit f2251ab into develop Jul 1, 2021
@mjprilliman mjprilliman deleted the batt_dispatch_defaults branch July 1, 2021 22:51
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release battery bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants