Skip to content

Billing demand ratchets for energy charges#627

Merged
brtietz merged 27 commits into
developfrom
ratchet_demand_charges
Jun 1, 2021
Merged

Billing demand ratchets for energy charges#627
brtietz merged 27 commits into
developfrom
ratchet_demand_charges

Conversation

@brtietz

@brtietz brtietz commented May 26, 2021

Copy link
Copy Markdown
Collaborator

mjprilliman and others added 22 commits April 21, 2021 16:21

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to change the on_load name. I will wait for Paul's changes before approval.


0
1017
on_load{'Utility Rate - Ratchet Demand Charges'} = define() {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be on_load{'Utility Rate - Billing Demand Percentages'} = define() { to match UI form name

Convert copy peaks from load page button to checkbox.

Conditional message to provide feedback on peak demand for Year 0 status.

Update defaults for new checkbox variable.

Rename UI form to avoid confusion with future implementation of demand ratchets.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added commits to improve the UI and for new Help topic. These involved adding a new UI variable with defaults and changing the name of a UI form, so hope they don't result in merge issues.

All looks great! Thanks.

@sjanzou

sjanzou commented May 28, 2021

Copy link
Copy Markdown
Collaborator

@brtietz, looks like the CSP behind the meter configurations are failing...
image

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the CSP behind the meter failing configurations defaults and update the failing Travis-CI tests.
image

@cpaulgilman

Copy link
Copy Markdown
Collaborator

For MSLF / Commercial, I get this:

image

The defaults seem to be set correctly for CSP configurations:

image

@brtietz

brtietz commented May 28, 2021

Copy link
Copy Markdown
Collaborator Author

Oddly, what's shown in the defaults manager differs from what's in the text files:

image

I'll fix this manually and push the results.

…vert generic battery configurations to values from develop
@sjanzou

sjanzou commented May 29, 2021

Copy link
Copy Markdown
Collaborator

@brtietz looks good now. Let me know when you want a beta version.

@brtietz brtietz merged commit bb4b007 into develop Jun 1, 2021
@brtietz brtietz deleted the ratchet_demand_charges branch August 10, 2021 16:29
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release enhancement utility rate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants