Changed duration sizing defaults to kwh option, changed variable#606
Merged
Conversation
overwrites to be bidirectional to not lose kwh or h values
brtietz
requested changes
May 3, 2021
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
The functions for switching between kWh and h are working great, but my saved files from 2020.11.29r1 are still having their durations overwritten to a two hr battery. It's just displayed in kWh now.
kwh whenever kw or h changes
brtietz
approved these changes
May 3, 2021
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Looks good as of the latest commit. Thanks!
Collaborator
|
@mjprilliman, pull request looks good |
cpaulgilman
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fixes lost value issue when changing between kwh and h battery sizing options
-Implements bidirectional overwrites when switching between options to keep values for each option unless manually changed
-Sets default to kwh option for all battery configurations, as this is the existing method for sizing the battery.