FOM Battery Remove Sell Rate#603
Conversation
* For Battery FOM, change label for Electricity Rates page to Electricity Purchases and revise descriptions in UI labels. * Correct conditional display of electricity rates inputs: No sell rates, enforce buy all / sell all metering option. * Fix typo in Group Name for battery dispatch charge limits. * UI callback function to display a message and set sell rate to zero if user opens an old file with non-zero sell rates or LK script sets sell rate to non-zero value. * Modify version upgrade script to handle opening old FOM battery cases where sell rate is non-zero
|
This is great! I particularly like that this page now makes it clear that PPA is the alternative to the retail rate. Three testing notes/suggestions: (1) Change the default for "compensation rate for net excess generation" to $0:
I feel like having a non-zero number in a greyed out box is confusing. (2) The Fuel Cell page still allows the full suite of distributed generation options for Single Owner, these should line up with other FOM configurations:
(3) These constraints are not enforced with the "save / load rate from file" dialog. I can force a change to net billing using this file: |
brtietz
left a comment
There was a problem hiding this comment.
See previous comment for requested changes (probably should have just written them up here).
* Change default value of ur_nm_yearend_sell_rate for all configurations. * Fix Fuel Cell / Single Owner configuration: Use FOM version of electricity rates page and set default for en_electricity_rates to zero. * Change startup script function name from setup_utility_rate_optional() to setup_electricity_purchases() for clarity. * Fix Help stylesheet formatting for notes from underline to bold.
Changing default value of net excess generation compensation rate to zero may result in small changes in LCOE.
|
@brtietz Thanks for the feedback. I made changes to address the two issues you noted. I also ran the test script again in case changing the default excess compensation rate to zero affected results. The default rate was non-zero for several configurations, including ones like Physical Trough Commercial, and I set them all to zero. |
|
The fixes for (1) and (3) look great! For (2) it looks like the default for ur_metering_option for fuel cell single owner needs to change, now it's stuck on net metering:
|
For rate data CSV files with maximum usage units value of -1, reset to zero (kWh) and display UI message box. This may happen when a user used an older version of SAM to import a rate from the URDB with no value for the max usage field and then exported it to a CSV file. Revise messages in message boxes.
|
My latest commit 7fab175 fixes an issue when importing a rate data CSV with energy charge max usage units value of -1, which can happen when importing a CSV file containing data for a rate from the URDB where max usage units is set to -1. It also modifies the URDB download process to change usage units = -1 to zero to avoid this issue to begin with. |
brtietz
left a comment
There was a problem hiding this comment.
Recent changes look great, thanks!
For Battery FOM, change label for Electricity Rates page to Electricity Purchases and revise descriptions in UI labels. Add new Help page and revise descriptions.
Correct conditional display of electricity rates inputs: No sell rates, enforce buy all / sell all metering option.
Fix typo in Group Name for battery dispatch charge limits.
UI callback function to display a message and set sell rate to zero if user opens a file created with SAM 2020.11.29 r1 with non-zero sell rates or if LK script sets sell rate to non-zero value.
Modify version upgrade script to handle opening old FOM battery cases where sell rate is non-zero. To test, try opening these files created with SAM 2020.2.29 or older that incorrectly allowed TOU sell rates:
fom-battery-sell-rate-tests.zip