SolarAnywhere fixes for Solar Resource File Converter macro#601
Merged
Conversation
* Include Albedo data in conversion from SA to SAM CSV format * Include particulate matter (PM) data even if SAM doesn't use it by request of CPR * Improve method of differentiating between SA and SA TMY3 formats * Correct conversion of snow depth data from m to cm
sjanzou
approved these changes
May 8, 2021
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
I like the leap year function - we should go for consistency everywhere. The other changes are very specific to the latest API updates and seem good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554 and #568
Updates for SolarAnywhere v3.5
Improve handling of leap year data
Fix snow depth units
Include particulate matter (PM) data when available
To test:
From any PV, PVWatts, or solar case, run the Solar Resource File Converter macro on these files:
sa-files-for-tests.zip