Skip to content

Contour plot of system power generated on summary page#571

Closed
mjprilliman wants to merge 2 commits into
patchfrom
heatmap_month_by_day
Closed

Contour plot of system power generated on summary page#571
mjprilliman wants to merge 2 commits into
patchfrom
heatmap_month_by_day

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

-Contour plot of 365 days by 24 hours showing kW generated each hour
-Available for all models with time series outputs
-Matches appearance of year 1 data on Heatmaps tab

@mjprilliman mjprilliman added this to the 2020.11.29 Patch 2 milestone Mar 26, 2021
@mjprilliman mjprilliman self-assigned this Mar 26, 2021

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We may want to change to months along the bottom in another pull request.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this example for Detailed PV / Single Owner, I'm confused by the kWh units in the title, and the hours in the x-axis that go to 365. I was expecting kW and 8760 given that the values in the legend appear to be kW.

image

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

In this example for Detailed PV / Single Owner, I'm confused by the kWh units in the title, and the hours in the x-axis that go to 365. I was expecting kW and 8760 given that the values in the legend appear to be kW.

image

Did you pull the latest changes on this branch? When I run that example I get the following:

image

As for the axes, the graph is 24 hours/day by 365 days/year = 8760 hours/year for the first year. This matches the Heatmap graph for the first year of the analysis.

@cpaulgilman

Copy link
Copy Markdown
Collaborator

I built my test version from SSC branch https://github.com/NREL/ssc/tree/heatmap_day_by_hour. Should I build from patch branch of SSC instead?

@sjanzou

sjanzou commented Mar 30, 2021

Copy link
Copy Markdown
Collaborator

@mjprilliman, will these changes go into patch and develop ssc and SAM?

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

@mjprilliman, will these changes go into patch and develop ssc and SAM?

Yes, once I resolve the Travis test issues these changes will go into patch and develop.

@sjanzou

sjanzou commented Mar 31, 2021

Copy link
Copy Markdown
Collaborator

Linux build fails due to trying to merge into patch with failing main.cpp from develop that was merged into heatmap_month_by_day. I thought the procedure was to branch off of patch for anything to go into patch and then after patch is running to merge into develop.

The specific issue is due to the following:
main.cpp line 2809 trying to use a void return as a boolean.

/home/sjanzou/Public/Projects/GitHub/NREL/SAM/src/main.cpp:2809:49: error: could not convert ‘set_python_path(python_path.std::basic_string<_CharT, _Traits, _Alloc>::c_str<char, std::char_traits, std::allocator >())’ from ‘void’ to ‘bool’
if (!set_python_path(python_path.c_str()))

The develop branch of ssc has set_python_path returned as an int so can ve converted to bool, so the develop branch of ssc works with the develop branch of SAM.

In this pull request, if the develop branch of ssc is used, then everything will build and if the patch branch of ssc is used (as on Travis-CI) everything will fail.

So, we need to keep all the dependent repos on the same root branch (either patch or develop) and be sure not to merge develop into a pull request branch that requests being merged into patch.

Hopefully, this makes sense. Revising and resubmitting this pull request now...

sjanzou added a commit that referenced this pull request Mar 31, 2021
@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Closing this branch because the root branches were messed up. The additions were added in a new PR.

@mjprilliman mjprilliman closed this Apr 1, 2021
@mjprilliman mjprilliman deleted the heatmap_month_by_day branch April 1, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants