Batt UI reorgazine inputs#569
Merged
Merged
Conversation
than desired bank power
Move cell nominal voltage and cell capacity from Battery Voltage to Battery Current and Capacity form, requires new UI variables to store copies. Vertical radio buttons instead of horizontal for consistent alignment across operating systems. Fix enabling of electrochemical vs voltage table inputs for battery chemistries: Vanadium flow enable electrochemical but only with nominal voltage input, and disable electrochemical for Iron flow. Add defaults for new UI variables.
Collaborator
Author
|
I need to add defaults for Fuel Cell configurations before merging this. |
mjprilliman
approved these changes
Mar 25, 2021
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me once the Fuel Cell defaults are updated
Collaborator
|
@cpaulgilman I believe this is good to merge now. The batt_sizing_bug_fix merge changed .travis.yml to "develop" but merging patch in changed it back to "patch". @brtietz is that correct? |
Collaborator
|
@mjprilliman Yes, the updated travis config is working as expected for this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.