Fix NSRDB API error handling#541
Merged
Merged
Conversation
* For NSRDB API calls, send user email <USEREMAIL> from registration (in registry) instead of hard-coded sam.support@nrel.gov. * Show API messages when they are generated, e.g., for invalid email address or API key both in UI callback and nsrdb.cpp. * Fix messages about lat/lon format (attempting to provide user guidance when they enter coordinates in degress minutes instead of decimal degrees).
sjanzou
approved these changes
Feb 20, 2021
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Just checking the webapis.conf was updated in SAM-private too... I will double check when building the patch
| @@ -4,7 +4,7 @@ | |||
| android_build=https://sam.nrel.gov/sites/default/files/content/mobile/android/readme.html | |||
| forum=https://sam.nrel.gov/support | |||
| ios_build=https://sam.nrel.gov/sites/default/files/content/mobile/ios/readme.html | |||
Collaborator
There was a problem hiding this comment.
Is this the same as PR#58 into SAM-private?
Collaborator
Author
There was a problem hiding this comment.
Yes, SAM-private PR#58 is supposed to go with this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #531