Make ppa and lease term variables in TPO model parametric#536
Merged
Conversation
Collaborator
Author
cpaulgilman
approved these changes
Feb 12, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Might consider making lease_or_ppa available as a parametric as well as we've done for the PPA models solution mode:
It's potentially confusing to run a parametric on monthly lease price when in PPA price mode, so this would at least make it possible to set the mode from parametrics.
Thanks,
Paul.
janinefreeman
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-First year monthly price and first year ppa price and their respective escalation rates now parametric