Skip to content

Batt cutoff voltage#502

Merged
mjprilliman merged 25 commits into
developfrom
batt_cutoff_voltage
Mar 19, 2021
Merged

Batt cutoff voltage#502
mjprilliman merged 25 commits into
developfrom
batt_cutoff_voltage

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

-Add battery cutoff voltage to UI for input to voltage model
-Currently only works for dynamic voltage model (lithium ion)

@brtietz

brtietz commented Jan 21, 2021

Copy link
Copy Markdown
Collaborator

First impressions on pulling up the GUI:

When I first open the "Battery Voltage" pane, the first entry for Cell cutoff voltage looks like an input:

image

but then as soon as I mouse over it, it changes to calculated:

image

We can talk more about Qfull after cutoff implementation and the calculated cell cutoff voltage field at the meeting.

I noticed you updated the defaults, which is good, but battery parameters that vary with chemistry are also in JSON files that are loaded when the chemistry changes. Should cutoff voltage be added to these files?

Should the cutoff voltage be greyed out when the voltage table is used? It might make sense to move these to "electrochemical properties" rather than "voltage properties"

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

First impressions on pulling up the GUI:

When I first open the "Battery Voltage" pane, the first entry for Cell cutoff voltage looks like an input:

image

but then as soon as I mouse over it, it changes to calculated:

image

We can talk more about Qfull after cutoff implementation and the calculated cell cutoff voltage field at the meeting.

I noticed you updated the defaults, which is good, but battery parameters that vary with chemistry are also in JSON files that are loaded when the chemistry changes. Should cutoff voltage be added to these files?

Should the cutoff voltage be greyed out when the voltage table is used? It might make sense to move these to "electrochemical properties" rather than "voltage properties"

I noticed the first issue yesterday it's an issue with the initialization in my callback script that I still need to fix. And how the value is defined is up for discussion as well. Right now, unchecked should display a calculated value of 0.66*Vnom, while checked should change to an input where the user inputs the cutoff voltage.

I wasn't aware of those JSON files for the battery parameters so I'd refer to your judgement on that. The behavior for the voltage table was one of my discussion points for the meeting.

Comment thread deploy/runtime/ui/Battery Voltage.txt Outdated
@mjprilliman mjprilliman added this to the SAM Fall 2021 Release milestone Jan 21, 2021
@mjprilliman mjprilliman requested a review from brtietz February 5, 2021 00:14
t = i*0.10;
q0 = Qfull - I*t;
V = E0 - R*I - K*(Qfull/(Qfull-I*t)) + A*exp(-B*I*t);
V = E0 - R*I - K*(Qfull_cutoff/(Qfull_cutoff -I*t))+ A*exp(-B*I*t);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formula in SSC looks like it has one more instance of Qfull than this one. Is that true or am I missing something?

@mjprilliman mjprilliman merged commit 69cf86a into develop Mar 19, 2021
@dguittet dguittet deleted the batt_cutoff_voltage branch August 23, 2021 18:35
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release battery enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants