Skip to content

Fix tower height cost issue#475

Merged
cpaulgilman merged 2 commits into
patchfrom
sam471-tower-height-cost-issue
Dec 14, 2020
Merged

Fix tower height cost issue#475
cpaulgilman merged 2 commits into
patchfrom
sam471-tower-height-cost-issue

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator
  • Add h_tower to UI equation for ui_tower_height input variable.
  • Adjust group box widths to match O&M costs form
  • Fix alignment issues

* Add h_tower to UI equation for ui_tower_height input variable.
* Adjust group box widths to match O&M costs form
* Fix alignment issues
@Matthew-Boyd

Copy link
Copy Markdown
Contributor

Can you explain this issue to me? I see that changing the tower height on the Tower and Receiver page does not update the same-named calculated variable on the System Costs page, but do we know why this happened? The input on the Tower and Receiver page is named 'THT' and 'h_tower' is just calculated by returning 'THT'. Now we're simplifying this equation by just returning 'h_tower' instead of either 'h_tower' or 'THT', but it doesn't appear it would affect the outcome (although it does). What am I missing?

@cpaulgilman

Copy link
Copy Markdown
Collaborator Author

The change that fixes this issue is on the Tower SolarPilot Capital Costs form not on the Tower Capital Costs form. The ui_tower_height input was not assigned on Tower SolarPilot Capital Costs,

The Tower Capital Costs form is used by the ISCC and DSPT models, which are both disabled in SAM 2020.11.29. I made the change there in case we bring those models back to life in the future. The h_tower variable is assigned on Tower and Receiver input page for all of the tower technologies, so there is no need for the IF statement on the costs page to determine whether to use h_tower or THT. UI forms that assign h_tower are: Direct Steam Tower Receiver, ISCC Molten Salt Tower Receiver, Molten Salt Tower Receiver, and MSPT receiver.

@Matthew-Boyd

Copy link
Copy Markdown
Contributor

Thanks, that should have been obvious. I added a commit to align one of the adjacent input boxes.

@cpaulgilman cpaulgilman merged commit a230b63 into patch Dec 14, 2020
@dguittet dguittet deleted the sam471-tower-height-cost-issue branch December 23, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants