Skip to content

move puerto rico download macro to the sample lk scripts folder#473

Closed
brtietz wants to merge 2 commits into
patchfrom
move_pr_macro
Closed

move puerto rico download macro to the sample lk scripts folder#473
brtietz wants to merge 2 commits into
patchfrom
move_pr_macro

Conversation

@brtietz

@brtietz brtietz commented Dec 8, 2020

Copy link
Copy Markdown
Collaborator
  • Move the macro from deploy/runtime/macros to samples/lk scripts for sam
  • Remove all references to "macro" and the macro inputs comments
  • Add hardcoded default inputs to match macro defaults
  • Move URLs from webapis.conf to the lk script, since importing the url from webapis.conf automatically adds the API key, which doesn't work with the open source version

Note: these URLs can be removed from SAM-Private's webapis.conf file after this PR is merged.

…e puerto rico is now supported by the nsrdb api directly
@brtietz brtietz added this to the 2020.11.29 Patch 1 milestone Dec 8, 2020
@brtietz brtietz requested a review from cpaulgilman December 8, 2020 20:59
* Convert macro instruction block to LK comment block (at top)
* Fix "all" download option to read email and api_key from inputs table
* Revise comments for clarity
* Test p50/p90 simulations with downloaded files
@brtietz

brtietz commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator Author

Merged in 8e3245d

@brtietz brtietz closed this Dec 10, 2020
@dguittet dguittet deleted the move_pr_macro branch December 23, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants