PV Snow Macro: Fix conversion when snow data expressed in inches#2079
Merged
Conversation
cpaulgilman
approved these changes
Apr 28, 2025
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. This fixes the snow depth conversion from inches to cm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If one attempts to use the macro available in various PV configurations to append snow data measured in inches, the conversion step of the macro will fail with an unintuitive error message. This PR fixes this bug.
To test:
Create a new PV system. Download a weather file. Download the attached snow data. Attempt to append it to the weather file you download, selecting a header of size 1, a column name of (Observed) Snow Depth (in), and units as inches. The macro will fail. This PR fixes that failure.
Fixes # (issue(s)): None yet.
Corresponding branches and PRs:
None applicable.
Unit Test Impact:
None applicable.
Checklist
denver, co_DVNC2_observed_snow_depth.csv