Fix UI callback crit_load check for Custom Generation Battery configs#2049
Conversation
brtietz
left a comment
There was a problem hiding this comment.
The changes fix the bug, but I think there might be a little more work to do to clean up lingering references to generic battery. In addition to the one here, a 'find in files' search turned up suspicious references to Generic Battery in runtime/reports/pvbattery.samreport
| "\tis_critical_load_tech = ( tech == 'PV Battery' \r", | ||
| "\t || tech == 'Custom Generation Battery'\r", | ||
| "\t || tech == 'Standalone Battery' \r", | ||
| "\t || tech == 'Generic Battery' \r", |
There was a problem hiding this comment.
Is there a reason Generic Battery is still in this list?
…plate Note that pvbattery.samreport template does not support Custom Generation Battery, so this does not affect any functionality.
No. That was an oversight. Thanks for pointing it out.
I took care of that one -- it doesn't affect any functionality because the report template is not configured for the Generic Battery configurations. Additional work on the template is required to support PDF reports for Custom Generation Battery configurations, but I did change the references to "Generic Battery" to "Custom Generation Battery" in the scripts. |
Pull Request Template
Description
Fix UI checks for critical load length to work with Custom Generation Battery configurations.
See #2048 for test procedure and sample file.
Fixes #2048
Checklist
Reminders- this section can be deleted
Checking for PySAM Incompatible API Changes.
When do the PySAM files need to be regenerated?