Conversation
Remaining items before pull request 1. Test old project files 2. Decide whether to update existing 1e+38 in defaults to Infinity 3. Test pysam build 4. Rerun defaults
mjprilliman
left a comment
There was a problem hiding this comment.
Energy charges with max usage of 'nan' gives the same results as max usage 'inf'. What does max usage 'nan' represent? Not a super likely use case, just curious
Not sure where this would be relevant, but this also allows for -nan and -inf inputs.
#2043 needs to be merged to fix the ME tidal issue
Thanks for testing. The marine-ui-updates branch was merged in to fix the defaults issue. ssc pull request NatLabRockies/ssc#1309 was created to address the nan, -nan, and -inf handling. Now, 1e+38 and inf for max tiers gives same result and negative values and NaNs throw errors
|
|
This specifically addresses #1856 by adding support for NaN and Inf in the DataMatrix widgets for electricity rate inputs. However, it is not possible to type "Inf" for numeric inputs with default value of 1e38 like incentives. Do we want NaN and Inf to work for all numeric inputs?
|
@cpaulgilman , that was the next question (or issue) to replace all 1e+38 with inf in defaults. We now support saving and loading inf and NaN values directly in JSON. |
Throw error for NaN (or -NaN) or negative max tier usage. Merging per 4/2/2025 meeting and per reviews of SAM NatLabRockies/SAM#2047
Addresses SAM issue #1856 to use Inf values as tier maximum usages.
Fixes #1856
Goes with ssc pull request NatLabRockies/ssc#1309
expected changes in test_results files - doubles are written out to full precision and NaN and Inf are directly supported - expect results to differ slightly.
Checklist
PySAM regeneration should be tested
ME Tidal LCOE calculator defaults seems to have an issue in the equations.