Combine cases macro checks lifetime mode#2012
Merged
brtietz merged 2 commits intoFeb 20, 2025
Merged
Conversation
sjanzou
requested changes
Feb 19, 2025
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Can you please change the error message from the technology name to the case name? For example in the attached project file, change "PVWatts" to "subhourly" in the error message:
Referenced project file
SAM_PR_2012.zip
Collaborator
Author
Thanks for testing! Fixed in latest push. |
sjanzou
approved these changes
Feb 20, 2025
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Great! Thanks for addressing the subhourly/hourly combination!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add code to check whether or not a simulation uses lifetime mode prior to assessing whether or not the simulation is subhourly
Fixes #1752
To test: Create a PVWatts case with a subhourly weather file, a PVWatts case with an hourly weather file, and a custom generation case that combines these two cases. The combine cases script should flag the fact that a case is subhourly and give an error that it is not currently supported.
Type of change
Please delete options that are not relevant.